Fix support for void nodes #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #5 (comment). But if this was causing an exception, then I do think unknown nodes (such as break) should be ignored and handled gracefully |
|
Perhaps this PR could be generalized so that nodes that don't have the required fields would be ignored. |
|
Yeah. I think if you do: children = ('length' in node ? node : node.children) || []on what was L28 that’d work fine? |
|
And a test of the form: t.equal(toString(u('foo')), '', 'should support voids') |
|
Good morning @wooorm! I updated this PR according to your suggestions :) |
wooorm
approved these changes
May 4, 2021
|
Good morning André! 🌞 Thanks, released in 3.0.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
I tested and deployed this change in staltz/strip-markdown-oneline@347709e too
Closes #5